Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors with RTD build #200

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

NicerNewerCar
Copy link
Contributor

@NicerNewerCar NicerNewerCar commented Aug 28, 2023

From RTD build 21745032:

Error
The configuration key "build.os" is required to build your documentation. Read more at https://docs.readthedocs.io/en/stable/config-file/v2.html#build-os

From RTD build 21745423:

Running Sphinx v7.2.4

Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/user_builds/autoscoper/envs/200/lib/python3.10/site-packages/sphinx/cmd/build.py", line 293, in build_main
    app = Sphinx(args.sourcedir, args.confdir, args.outputdir,
  File "/home/docs/checkouts/readthedocs.org/user_builds/autoscoper/envs/200/lib/python3.10/site-packages/sphinx/application.py", line 233, in __init__
    self.setup_extension(extension)
  File "/home/docs/checkouts/readthedocs.org/user_builds/autoscoper/envs/200/lib/python3.10/site-packages/sphinx/application.py", line 406, in setup_extension
    self.registry.load_extension(self, extname)
  File "/home/docs/checkouts/readthedocs.org/user_builds/autoscoper/envs/200/lib/python3.10/site-packages/sphinx/registry.py", line 460, in load_extension
    metadata = setup(app)
  File "/home/docs/checkouts/readthedocs.org/user_builds/autoscoper/envs/200/lib/python3.10/site-packages/notfound/extension.py", line 337, in setup
    from sphinx.builders.html import setup_js_tag_helper
ImportError: cannot import name 'setup_js_tag_helper' from 'sphinx.builders.html' (/home/docs/checkouts/readthedocs.org/user_builds/autoscoper/envs/200/lib/python3.10/site-packages/sphinx/builders/html/__init__.py)

Exception occurred:
  File "/home/docs/checkouts/readthedocs.org/user_builds/autoscoper/envs/200/lib/python3.10/site-packages/notfound/extension.py", line 337, in setup
    from sphinx.builders.html import setup_js_tag_helper
ImportError: cannot import name 'setup_js_tag_helper' from 'sphinx.builders.html' (/home/docs/checkouts/readthedocs.org/user_builds/autoscoper/envs/200/lib/python3.10/site-packages/sphinx/builders/html/__init__.py)
The full traceback has been saved in /tmp/sphinx-err-x_aeh0nv.log, if you want to report the issue to the developers.
Please also report this if it was a user error, so that a better error message can be provided next time.
A bug report can be filed in the tracker at <https://github.com/sphinx-doc/sphinx/issues>. Thanks!

This was caused by the sphinx-notfound-page package being broken on Sphinx 7.2.0+ , see readthedocs/sphinx-notfound-page#219

@NicerNewerCar NicerNewerCar changed the title BUG: Fix missing fields in RTD config Fix errors with RTD build Aug 28, 2023
@NicerNewerCar NicerNewerCar force-pushed the rtd-build-error-fix branch 2 times, most recently from 4797908 to 85463b4 Compare August 28, 2023 19:02
@NicerNewerCar NicerNewerCar requested a review from jcfr August 28, 2023 19:05
@NicerNewerCar NicerNewerCar mentioned this pull request Aug 28, 2023
@jcfr
Copy link
Contributor

jcfr commented Aug 29, 2023

Thanks again for addressing this 🙏

@jcfr jcfr merged commit fe1d6d4 into BrownBiomechanics:main Aug 29, 2023
2 checks passed
@NicerNewerCar NicerNewerCar deleted the rtd-build-error-fix branch August 29, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants